WCA Live Result Admin #1: Submit and Updating Results #10776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
requested changes
Feb 6, 2025
app/controllers/live_controller.rb
Outdated
Comment on lines
42
to
52
| new_attempts = results.map.with_index(1) do |r, i| | ||
| same_result = previous_attempts.find_by(result: r, attempt_number: i) | ||
| if same_result.present? | ||
| same_result | ||
| else | ||
| different_result = previous_attempts.find_by(attempt_number: i) | ||
| new_result = LiveAttempt.build(result: r, attempt_number: i) | ||
| different_result&.update(replaced_by_id: new_result.id) | ||
| new_result | ||
| end | ||
| end |
There was a problem hiding this comment.
Note to self: I have a hunch there might be an even more efficient way to handle this.
There was a problem hiding this comment.
Will play around later when I have more headspace.
kr-matthews
reviewed
Feb 12, 2025
Comment on lines
81
to
85
| useEffect(() => { | ||
| if (results) { | ||
| setAttempts(results[currentIndex].attempts.map((a) => a.result)); | ||
| } | ||
| }, [currentIndex, results]); |
There was a problem hiding this comment.
Is the query ever re-fetched? i.e. Does results ever change? If not, then you indeed do need a side effect to set attempts when the data first loads, but you could explicitly update attempts when the "<" or ">" button is clicked instead of it being a side effect of the index changing. That would minimize the use of effects (even though it's the same number of useEffects, that effect would only be happening once).
gregorbg
reviewed
Feb 12, 2025
gregorbg
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple Submitting/Updating Results and double checking them. Does not include calculating advancing/rankings/records. Those will be follow up PRs (which I have already done, but I want to add tests).
Have not checked if I deleted everything related to those features, will do after dinner.